[kholidays] [Bug 383896] New: Israel's holidays are not displayed

[Wolfgang Bauer]

https://bugs.kde.org/show_bug.cgi?id=383896

Bug ID: 383896
Summary: Israel's holidays are not displayed
Product: kholidays
Version: git
Platform: openSUSE RPMs
URL: http://bugzilla.opensuse.org/show_bug.cgi?id=1053947
OS: Linux
Status: UNCONFIRMED
Severity: normal
Priority: NOR
Component: general
Assignee: kdepim-***@kde.org
Reporter: ***@tmo.at
Target Milestone: ---

If you choose "Israel (English)" or "Israel (Hebrew)" holidays in KOrganizer's
settings (and restart KOrganizer), no holidays are displayed at all.

I suppose that's because kholidays' QCalendarSystem class
(src/parsers/qcalendarsystem.cpp) seems to have no support for the Hebrew
calendar implemented.

That's with the latest version 5.6.0 (from KDE Applications 17.08.0).

[b***@kde.org]

https://bugs.kde.org/show_bug.cgi?id=383896

***@orbsky.homelinux.org changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@orbsky.homelinux.org

[Luigi Toscano]

https://bugs.kde.org/show_bug.cgi?id=383896

Luigi Toscano <***@tiscali.it> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@tiscali.it
Status|REPORTED |CONFIRMED
Ever confirmed|0 |1

--- Comment #1 from Luigi Toscano <***@tiscali.it> ---
This is still valid. Reported on IRC and confirmed by a quick check with
kholidays 5.52 (now in Frameworks).

[b***@kde.org]

https://bugs.kde.org/show_bug.cgi?id=383896

***@shimi.net changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@shimi.net

--- Comment #2 from ***@shimi.net ---
(In reply to Luigi Toscano from comment #1)

Post by Luigi Toscano
This is still valid. Reported on IRC and confirmed by a quick check with
kholidays 5.52 (now in Frameworks).

I'm the reporter on IRC.

I would like to emphasize that this is not sure Israel's holidays as can be
understood from the title of this bug. Right, they're "assigned" to "Israel",
but in fact all Israel's holidays are in fact the Jewish holidays, celebrated
by all Jews across the world. We're talking about Passover, Hannukah etc. So
whenever someone, Jewish or not, wants to know when is Hannukah this year
(which is a different day every year on the Gregorian calendar) - they
basically can't do that with Plasma 5.

I would ALSO like to emphasize, that this is A REGRESSION. This worked
perfectly in KDE 4, and was actually one of the "Linux" features I showed off
to friends as lacking in their corporate operating systems. Now it is gone :(

[Shimi]

https://bugs.kde.org/show_bug.cgi?id=383896

--- Comment #3 from Shimi <***@shimi.net> ---
(In reply to Shimi from comment #2)

Post by b***@kde.org
I would like to emphasize that this is not sure Israel's holidays as can be

Sorry: "this is not only about Israel's holidays" is what I meant to write.
Sorry about spam. Not sure how this got typed :)

[JanKusanagi]

https://bugs.kde.org/show_bug.cgi?id=383896

JanKusanagi <jan-***@gmx.co.uk> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |jan-***@gmx.co.uk

--- Comment #4 from JanKusanagi <jan-***@gmx.co.uk> ---
(In reply to Shimi from comment #2)

Post by b***@kde.org
was actually one of the "Linux" features I showed
off to friends as lacking in their corporate operating systems. Now it is
gone :(

The feature is not gone, there's just a bug with this particular locale.
The feature works perfectly fine for most other countries/locales.

I'll add that "Victory Day", the only Gregorian-based event in the Israel
holiday file, is handled correctly, so it's not like parsing the file fails.

[Allen Winter]

https://bugs.kde.org/show_bug.cgi?id=383896

Allen Winter <***@kde.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@kde.org

--- Comment #5 from Allen Winter <***@kde.org> ---
This comment is about KOrganizer and not the digital clock plasmoid that can
also show holidays.

We had a plugin for KOrganizer in the KDE4 days for a Jewish holidays and what
made it special was that it knew the Hebrew calendar. Indeed we never ported
that to KDE5.

In KDE5 days, we have holidays for Israel in English and translated to Hebrew.
for the locales en-us and he. It should know about the Hebrew calendar too.

When testing in KOrganizer, however, I don't see the religious holidays for
Israeli calendar . I do see the one holiday "Victory day" on the Gregorian
calendar.

For people wanting to see the Jewish holidays and don't want to load the Israel
holidays, then it makes sense to try and restore the Jewish holidays KOrganizer
plugin. except that doesn't work for the digital clock plasmoid.

Summary:
- restore KOrganizer Jewish holidays plugin
- figure out why religious holidays from the Israel calendar don't show up in
KOrganizer (should they? or should that function belong to the Jewish holidays
plugin?)
- what to do in digital clock about all this

I am the kholidays maintainer and former KOrganizer maintainer but my memory of
all this is kinda fuzzy.

[Allen Winter]

https://bugs.kde.org/show_bug.cgi?id=383896

--- Comment #6 from Allen Winter <***@kde.org> ---
(In reply to JanKusanagi from comment #4)

Post by JanKusanagi
The feature is not gone, there's just a bug with this particular locale.
The feature works perfectly fine for most other countries/locales.
I'll add that "Victory Day", the only Gregorian-based event in the Israel
holiday file, is handled correctly, so it's not like parsing the file fails.

"Perfectly fine"? really? where? how?
I'm not seeing any Jewish holidays when I load the Israel holiday file.

[b***@kde.org]

https://bugs.kde.org/show_bug.cgi?id=383896

--- Comment #7 from ***@orbsky.homelinux.org ---
Yep.... the problem still presists.

[Allen Winter]

https://bugs.kde.org/show_bug.cgi?id=383896

--- Comment #10 from Allen Winter <***@kde.org> ---
I may be the kholidays maintainer now, but I really need John Layt (the
original author) to help figure out why holidays on the Hebrew calendar aren't
showing up.

I don't know how to rotate hebrew calendar dates onto the gregorian calendar.
There isn't any code in kholidays that I can see where this might happen.

for now the best I can do is restore the Jewish holidays plugin for KOrganizer,
which is done in the master branch

[Shimi]

https://bugs.kde.org/show_bug.cgi?id=383896

--- Comment #11 from Shimi <***@shimi.net> ---
(In reply to Allen Winter from comment #10)

Post by Allen Winter
I don't know how to rotate hebrew calendar dates onto the gregorian
calendar. There isn't any code in kholidays that I can see where this might
happen.

Maybe
https://api.kde.org/4.12-api/kdepim-apidocs/korganizer/html/classHebrewDate.html
and
https://api.kde.org/4.12-api/kdepim-apidocs/korganizer/html/holiday_8cpp_source.html
?